Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade rspec travis et al #16

Merged
merged 11 commits into from
Nov 7, 2014

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jul 23, 2014

No description provided.

Fryguy added 2 commits July 23, 2014 00:37
This conversion is done by Transpec 2.3.6 with the following command:
    transpec

* 219 conversions
    from: obj.should
      to: expect(obj).to

* 116 conversions
    from: == expected
      to: eq(expected)

* 34 conversions
    from: be_false
      to: be_falsey

* 31 conversions
    from: obj.should_not
      to: expect(obj).not_to

* 29 conversions
    from: be_true
      to: be_truthy

* 16 conversions
    from: lambda { }.should
      to: expect { }.to

For more details: https://github.com/yujinakayama/transpec#supported-conversions
@coveralls
Copy link

Coverage Status

Coverage increased (+6.51%) when pulling 6931233 on Fryguy:upgrade_rspec_travis_et_al into beb386b on ManageIQ:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.51%) when pulling b956819 on Fryguy:upgrade_rspec_travis_et_al into beb386b on ManageIQ:master.

@Fryguy
Copy link
Member Author

Fryguy commented Aug 22, 2014

@jrafanie Travis is now working for rubinius, and it seems there's a bug against rbx...need to see if this is something rbx specific, or if it should be happening on other rubies as well.

Ruby 2.1 complains when reject is called on a Hash with a
default value.  Switching to select doesn't complain.

See also http://globaldev.co.uk/2014/05/ruby-2-1-in-detail/#hashreject
@Fryguy Fryguy force-pushed the upgrade_rspec_travis_et_al branch from b956819 to 64a843f Compare August 25, 2014 15:20
@coveralls
Copy link

Coverage Status

Coverage increased (+6.51%) when pulling 64a843f on Fryguy:upgrade_rspec_travis_et_al into beb386b on ManageIQ:master.

@Fryguy Fryguy mentioned this pull request Nov 6, 2014
@Fryguy Fryguy force-pushed the upgrade_rspec_travis_et_al branch from 327a6c9 to 7b43872 Compare November 6, 2014 22:09
@Fryguy Fryguy force-pushed the upgrade_rspec_travis_et_al branch from 7b43872 to 526f068 Compare November 6, 2014 22:13
@miq-bot
Copy link
Member

miq-bot commented Nov 6, 2014

Checked commits Fryguy@4a880e9 .. Fryguy@526f068 with rubocop 0.21.0
15 files checked, 94 offenses detected

spec/core_ext/array/duplicates_spec.rb

spec/core_ext/array/element_counts_spec.rb

spec/core_ext/array/inclusions_spec.rb

spec/core_ext/array/random_spec.rb

spec/core_ext/array/tableize_spec.rb

spec/core_ext/hash/deletes_spec.rb

spec/core_ext/hash/nested_spec.rb

spec/core_ext/string/hex_dump_spec.rb

jrafanie added a commit that referenced this pull request Nov 7, 2014
@jrafanie jrafanie merged commit be61d70 into ManageIQ:master Nov 7, 2014
@Fryguy Fryguy deleted the upgrade_rspec_travis_et_al branch November 8, 2014 19:55
Fryguy added a commit that referenced this pull request Dec 2, 2015
- Breaking changes
 - Remove Object#namespace [#20]

- Other changes
  - Add ability to pass a transformation block to element_counts [#21]
  - Array#include_any? and friends now accept a single argument Array.
    [#18]
  - Upgraded to RSpec 3 [#16]
  - Added CHANGELOG.md!
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants