Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Drop runtime dependency on ActiveSupport due to minimum ruby requirement #22

Merged

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jul 6, 2016

more_core_extensions/core_ext/object/blank.rb was copied from
https://github.com/rails/rails/blob/v5.0.0/activesupport/lib/active_support/core_ext/object/blank.rb

With the release of ActiveSupport v5.0.0 a minimum required_ruby_version
of '>= 2.2.2' was added. The code for Blank has been copied here so that
we can continue to support ruby versions that don't meet that requirement.

The test was mostly copied as well, but rewritten in rspec syntax.

ActiveSupport has been added as a development dependency for ruby >= 2.2.2
to allow for testing nested hash features with HashWithIndifferentAccess

@bdunne
Copy link
Member Author

bdunne commented Jul 6, 2016

@Fryguy Please review.

cc @jrafanie @gmcculloug

@bdunne
Copy link
Member Author

bdunne commented Jul 6, 2016

I'll rework ManageIQ/ovirt#57 after this is merged.

@bdunne bdunne force-pushed the drop_runtime_dependency_on_activesupport branch from c26858a to 64b360b Compare July 6, 2016 21:18
more_core_extensions/core_ext/object/blank.rb was copied from
https://github.com/rails/rails/blob/v5.0.0/activesupport/lib/active_support/core_ext/object/blank.rb

With the release of ActiveSupport v5.0.0 a minimum required_ruby_version
of '>= 2.2.2' was added.  The code for Blank has been copied here so that
we can continue to support ruby versions that don't meet that requirement.

The test was mostly copied as well, but rewritten in rspec syntax.

ActiveSupport has been added as a development dependency for ruby >= 2.2.2
to allow for testing nested hash features with HashWithIndifferentAccess
@bdunne bdunne force-pushed the drop_runtime_dependency_on_activesupport branch from 64b360b to 72af99c Compare July 6, 2016 21:41
@miq-bot
Copy link
Member

miq-bot commented Jul 6, 2016

Checked commits bdunne/more_core_extensions@72af99c~...288f0d0 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
6 files checked, 6 offenses detected

lib/more_core_extensions/core_ext/object/blank.rb

spec/core_ext/hash/nested_spec.rb

@bdunne
Copy link
Member Author

bdunne commented Jul 7, 2016

Not planning to make any additional rubocop changes since the majority of that code is copied.

@Fryguy Fryguy merged commit 8fb5eaa into ManageIQ:master Jul 7, 2016
@bdunne bdunne deleted the drop_runtime_dependency_on_activesupport branch July 7, 2016 15:12
@jrafanie
Copy link
Member

jrafanie commented Jul 7, 2016

Nice work @bdunne 👏

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants