add descendant_get to readme #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
requested changes
Jun 28, 2017
README.md
Outdated
| @@ -71,6 +71,8 @@ MoreCoreExtensions are a set of core extensions beyond those provided by ActiveS | |||
|
|
|||
| * core_ext/module/namespace.rb | |||
| * `#in_namespace?` - Returns whether or not the object is in the given namespace | |||
| * core_ext/module/descendants.rb | |||
There was a problem hiding this comment.
Can this be above namespace? I think everything else is alphabetized.
jntullo
force-pushed
the
descendant_get_readment
branch
from
6a36651 to
5eaeee4
Compare
|
Checked commit jntullo@5eaeee4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
bdunne
approved these changes
Jun 28, 2017
|
@jntullo Version 3.3.0 has been released with these changes |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Readme to include
#descendant_get@miq-bot assign @Fryguy
cc: @bdunne