Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move cache_with_timeout extension from ManageIQ #51

Merged
merged 2 commits into from
Jul 27, 2017

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jul 26, 2017

@bdunne Please review.

@Fryguy Fryguy force-pushed the add_cache_with_timeout branch from afc1166 to a85bc60 Compare July 27, 2017 13:32
@miq-bot
Copy link
Member

miq-bot commented Jul 27, 2017

Checked commits Fryguy/more_core_extensions@20110df~...a85bc60 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 5 offenses detected

lib/more_core_extensions/core_ext/module/cache_with_timeout.rb

spec/core_ext/module/cache_with_timeout_spec.rb

Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@bdunne bdunne merged commit 5787af3 into ManageIQ:master Jul 27, 2017
@Fryguy Fryguy deleted the add_cache_with_timeout branch July 27, 2017 16:02
Fryguy added a commit that referenced this pull request Aug 11, 2017
Added
- Added Module#cache_with_timeout [[#51](#51)]

Changed
- Performance improvements to store_path [[#54](#54)]
  and fetch_path [[#55](#55)]
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants