Adds shared nested specs #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLaMuro
force-pushed
the
shared_nested_specs
branch
from
0feaae3 to
2461778
Compare
|
Checked commits NickLaMuro/more_core_extensions@98bcbc4~...2461778 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 spec/core_ext/shared/nested_spec.rb
|
Adds specs around Array and Hashes where each class is intermixed with the other. Further cements the current implementation of #store_path
|
Wow... well that didn't take much convincing ;) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds specs around shared/nested.rb for
#fetch_pathand#store_pathfor Arrays mixed with Hashes and vice-versa.Should ideally be merged prior to #54 and #55, and once merged, rebased into those two branches to confirm existing functionality.