Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

change header output to markdown vs postgres (using + vs |) #83

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Jun 24, 2020

Benchmark-sweet is using tableize and I was hoping no one would mind terribly about this exceedingly minor header output change.

maybe @kbrock would be willing to back this one?

@d-m-u d-m-u force-pushed the change_tableize_to_output_markdown_vs_postgres branch from 19d6867 to 9bac7cd Compare June 24, 2020 18:27
@miq-bot
Copy link
Member

miq-bot commented Jun 24, 2020

Checked commit d-m-u@9bac7cd with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@Fryguy
Copy link
Member

Fryguy commented Jun 24, 2020

Benchmark-sweet

what is that?


technically the table still isn't markdown compliant, but this would make it closer... I have no issue with this change. 👍

@Fryguy
Copy link
Member

Fryguy commented Jun 24, 2020

Seems the failures are still happening with the pause/resume stuff... I've opened #84 to track fixing that.

@d-m-u
Copy link
Contributor Author

d-m-u commented Jun 24, 2020

thanks Fryguy!
it's nifty, is what it is: https://github.com/kbrock/benchmark-sweet

Copy link
Member

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would make my life much easier.
I could avoid pasting in sublime, search replacing the + and then pasting into PRs or Gitter

after this change, it becomes markdown compliant / just works

thanks @d-m-u

@d-m-u d-m-u closed this Jun 25, 2020
@d-m-u d-m-u reopened this Jun 25, 2020
@chessbyte
Copy link
Member

Tests are passing (green), @Fryguy approved and @kbrock wants this. Merging.

@chessbyte chessbyte merged commit e5b4501 into ManageIQ:master Jun 25, 2020
@chessbyte chessbyte assigned chessbyte and unassigned Fryguy Jun 25, 2020
@d-m-u d-m-u deleted the change_tableize_to_output_markdown_vs_postgres branch June 25, 2020 13:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants