Add Object#deep_send #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are the callers of |
|
Checked commits Fryguy/more_core_extensions@c8a3dc0~...e61faef with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
|
Generally 👍 My only question is... From a more_core_extensions perspective, should we clean up the interface a bit before releasing the next version (this PR or another PR)? The method has a wide array of acceptable arguments (dotted string, multiple strings, multiple symbols, array). |
|
I'm fine with it as is, personally. |
50 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract from manageiq-gems-pending - https://github.com/ManageIQ/manageiq-gems-pending/blob/1b3f549d2f7386af9527285c945bb4c6ecbcff75/lib/gems/pending/util/extensions/miq-object.rb
@bdunne Please review.