Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add String#to_i_with_method and friends #95

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Add String#to_i_with_method and friends #95

merged 1 commit into from
Oct 26, 2020

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Oct 21, 2020 •
edited
Loading

@Fryguy
Copy link
Member Author

Fryguy commented Oct 21, 2020

Forgot to add documentation...will do shortly.

This was referenced Oct 21, 2020
Merged
Open
@Fryguy Fryguy force-pushed the to_i_with_method branch 2 times, most recently from 27d7141 to 8ad8372 Compare October 21, 2020 22:06
@Fryguy
Copy link
Member Author

Fryguy commented Oct 21, 2020

Ok, this is ready to go. I also updated the specs to be a bit more forceful, using eql instead of eq, so that we can be sure we are getting back a Float where expected without eq's type conversions hiding any bugs.

@miq-bot
Copy link
Member

miq-bot commented Oct 21, 2020

Checked commit Fryguy@703da3c with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
3 files checked, 0 offenses detected
Everything looks fine. ⭐

@bdunne bdunne merged commit 935f382 into ManageIQ:master Oct 26, 2020
@Fryguy Fryguy deleted the to_i_with_method branch October 27, 2020 14:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@bdunne bdunne

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fryguy @miq-bot @bdunne