Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove datatables dependencies #346

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Remove datatables dependencies #346

merged 1 commit into from
Sep 25, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Sep 13, 2018

looks like the original GTL implementation was based on datatables, and the styling was never removed afterwards.

Cc @karelhala

looks like the original GTL implementation was based on datatables, and the styling was never removed
@miq-bot
Copy link
Member

miq-bot commented Sep 13, 2018

Checked commit https://github.com/himdel/ui-components/commit/0fb2e39217c13bb50c0220cde6914f370a89184b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Contributor

@karelhala karelhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@martinpovolny martinpovolny merged commit c3d8fb1 into ManageIQ:master Sep 25, 2018
@martinpovolny martinpovolny self-assigned this Sep 25, 2018
@himdel himdel deleted the rm-datatables branch September 25, 2018 13:00
@himdel himdel added this to the Sprint 96 Ending Oct 8, 2018 milestone Sep 25, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants