-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Def tokens available on #7173
Merged
david-yz-liu
merged 9 commits into
MarkUsProject:master
from
umututku03:def-tokens-available-on
Aug 8, 2024
Merged
Def tokens available on #7173
david-yz-liu
merged 9 commits into
MarkUsProject:master
from
umututku03:def-tokens-available-on
Aug 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s into def-tokens-available-on
Pull Request Test Coverage Report for Build 10292680491Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
david-yz-liu
reviewed
Aug 7, 2024
…s into def-tokens-available-on
david-yz-liu
approved these changes
Aug 8, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Closes #7068. Currently, the default date for "Tokens available on" for Student-Run Tests (under Settings -> Automated Testing -> Student-Run Tests) is set to the assignment deadline. However, setting the default to the current time would be more logical. This change aims to improve the usability of the Student-Run Tests configuration by ensuring the "Tokens available on" field is pre-filled with a more appropriate default value.
...
Screenshots of your changes (if applicable)
(the current time that this screenshot was taken was 2024-08-07 at 6 33 51 PM)Associated documentation repository pull request (if applicable)
Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)