Display full runID and check icon when copied
#2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2940 +/- ##
=========================================
Coverage 81.16% 81.16%
Complexity 1506 1506
=========================================
Files 268 268
Lines 7363 7363
Branches 329 329
=========================================
Hits 5976 5976
Misses 1226 1226
Partials 161 161 ☔ View full report in Codecov by Sentry. |
davidjgoss
reviewed
Oct 22, 2024
| @@ -28,12 +30,13 @@ const MqEmpty: React.FC<MqCopyProps> = ({ string }) => { | |||
| event.stopPropagation() | |||
| navigator.clipboard.writeText(string) | |||
| setOpen(true) | |||
| setHasCopied(true) | |||
There was a problem hiding this comment.
Would we also want to revert the icon back say 3s after clicking via a setTimeout?
There was a problem hiding this comment.
Yeah, sorry I missed this, I'll do it right now. @wslulciuc I think the general consensus is that we should do this because that's how this feature works most of the time.
jonathanpmoraes
pushed a commit
to nubank/NuMarquez
that referenced
this pull request
Feb 6, 2025
Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>
jonathanpmoraes
pushed a commit
to nubank/NuMarquez
that referenced
this pull request
Feb 6, 2025
* Fixing data quality display. (MarquezProject#2937) Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Dataset Version call simplification (MarquezProject#2938) * Fixing data quality display. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Fixing dataset version calls. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> --------- Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * feat: allow db-migrate without version (MarquezProject#2936) Signed-off-by: David Goss <david@davidgoss.co> * Display full `runID` and check icon when copied (MarquezProject#2940) Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Deferred copy revert. (MarquezProject#2941) Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Long text handling (MarquezProject#2942) * Deferred copy revert. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Long text handling. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Adding search back in. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> --------- Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Use project root for docker volume prefix (MarquezProject#2943) Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * fix: Correct SQL query pagination for DatasetVersion findAll method (MarquezProject#2945) Signed-off-by: Alper İnan <kurumsal.alper@gmail.com> Signed-off-by: Alper <kurumsal.alper@gmail.com> * Update changelog for `0.50.0` Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Replace `redoc-cli` with `redocly` Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Prepare for release 0.50.0 Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Prepare next development version 0.51.0-SNAPSHOT Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Templatize event time in `metadata.json` (MarquezProject#2946) * Templatize event time in `metadata.json` Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Use `metadata.template.json` Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> --------- Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Update CHANGELOG.md * Update `web/docs/demo.gif` (MarquezProject#2948) Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * fix(deps): update dependency io.openlineage:openlineage-java to v1.23.0 (MarquezProject#2907) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency org.assertj:assertj-core to v3.26.3 (MarquezProject#2909) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Willy Lulciuc <willy@datakin.com> * fix(deps): update dependency org.postgresql:postgresql to v42.7.4 (MarquezProject#2912) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency org.opensearch.client:opensearch-rest-client to v2.17.1 (MarquezProject#2911) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Willy Lulciuc <willy@datakin.com> * fix(deps): update dependency org.apache.commons:commons-lang3 to v3.17.0 (MarquezProject#2908) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Ignore `**/stats/**` (MarquezProject#2952) Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Update compatibility for `0.50.0` * fix(deps): update dependency org.opensearch.client:opensearch-java to v2.16.0 (MarquezProject#2910) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * `Dataset.currentVersionUuid` `->` `DatasetVersion.uuid` (MarquezProject#2954) Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> * Update Events Page (MarquezProject#2955) * Tuning the events page for longer events. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Adding events file. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Refetch jobs button. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Refetch jobs button. Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> * Lint Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> --------- Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> Co-authored-by: Willy Lulciuc <willy@datakin.com> * Lineage run attachment issue. (MarquezProject#2953) Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> Co-authored-by: Willy Lulciuc <willy@datakin.com> * feature: Better handling of missing environment variables in setupProxy.js file. (MarquezProject#2956) Signed-off-by: Artur Owczarek <owczarek.artur@gmail.com> --------- Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com> Signed-off-by: David Goss <david@davidgoss.co> Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com> Signed-off-by: Alper İnan <kurumsal.alper@gmail.com> Signed-off-by: Alper <kurumsal.alper@gmail.com> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Artur Owczarek <owczarek.artur@gmail.com> Co-authored-by: Peter Hicks <phixMe@users.noreply.github.com> Co-authored-by: davidjgoss <david@davidgoss.co> Co-authored-by: Willy Lulciuc <willy@datakin.com> Co-authored-by: Alper İnan <65857758+inanalper@users.noreply.github.com> Co-authored-by: Willy Lulciuc <willy.lulciuc@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Artur Owczarek <owczarek.artur@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR displays the full
runID(when hovered) and check icon when copiedDisplay
RunIDon hover:Display check icon when
RunID: