Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[New Rule]: rewrite dict.get(key, None) as dict.get(key) #171

Closed
janosh opened this issue Mar 15, 2023 · 2 comments · Fixed by #173
Closed

[New Rule]: rewrite dict.get(key, None) as dict.get(key) #171

janosh opened this issue Mar 15, 2023 · 2 comments · Fixed by #173
Assignees
@MartinThoma
Labels
enhancement New feature or request

Comments

@janosh
Copy link

janosh commented Mar 15, 2023

Explanation

dict.get(key) returns None by default if key is missing.

Example

# Bad
dict.get(key, None)

# Good
dict.get(key)

Related

Adding this rule should be coordinated with astral-sh/ruff#3546 for consistent naming.
@janosh janosh added the enhancement New feature or request label Mar 15, 2023
@kyoto7250
Copy link
Contributor

I am interested in this issue. Would you mind if I tackle this issue?

In making this rule, what will the SIM number be?

@MartinThoma
Copy link
Owner

Go ahead :-) 🙏

The number should be SIM910

@janosh janosh mentioned this issue Mar 28, 2023
Closed
@kyoto7250 kyoto7250 mentioned this issue Mar 29, 2023
Merged
MartinThoma pushed a commit that referenced this issue Mar 30, 2023
@kyoto7250
ENH: Add dict.get(key, None) → dict.get(key) as SIM910 (#173)
21375ea 
See https://docs.python.org/3/library/stdtypes.html?highlight=dict#dict.get

Closes #171
@jakkdl jakkdl mentioned this issue Apr 19, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@MartinThoma MartinThoma

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: Add dict.get(key, None) → dict.get(key) as SIM910 kyoto7250/flake8-simplify
3 participants
@MartinThoma @janosh @kyoto7250