Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[persist] Follow through on requested batch deletes by default #31099

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

bkirwi
Copy link
Contributor

@bkirwi bkirwi commented Jan 17, 2025

Enabled widely by default with zero consequences so far.

Motivation

This has been baking in staging etc. widely with no issues for quite a while, and it's nice to clean up after oneself.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Enabled widely by default with zero consequences so far.
@bkirwi bkirwi requested a review from a team as a code owner January 17, 2025 21:24
@bkirwi bkirwi enabled auto-merge January 17, 2025 21:29
@bkirwi bkirwi merged commit 1ba2953 into MaterializeInc:main Jan 17, 2025
79 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants