Build BATS Docker image locally #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use virtualenv to install optimade into, removing the virtualenv at the end. Tried using pipx first, but this did not function as intended - so I defaulted to virtualenv. Updating the base of the Dockerfile to be a materials-consortia-specific bats image, which is to be created manually prior to building the Dockerfile image. Information about this must be added to the README.
First, build a custom BATS image using alpine3.15, as this alpine version is the latest to use Python 3.9.
Use setup_suite.bash to only create the entrypoint.sh copy once, instead of once for every file. Reset all defaults now also for each new test, instead of for each file run.
For more information see GHSA-f6pv-j8mr-w6rr
Install virtualenv in all Dockerfiles.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142
Fixes #123
By git cloning the bats-core repository locally and building the Dockerfile with the build argument
bashverto point to a specific bash Docker image tag, it is possible to use a specific alpine version, which in turn let's us use a specific Python version.We want to use the latest possible alpine version that uses Python 3.9 (as this is currently the minimum supported version for OPTIMADE Python tools). This alpine version is 3.15 (see the packages overview for confirmation, searching for
python3, changing the branch accordingly).Another, future, solution here, would be to build the custom BATS Docker image "once" and upload it to the GitHub container repository and use it there. I suggest doing this in another PR, however, for now. An issue should be opened for this around the merge-time of this PR.
Finally, as a bonus, the
set-outputusage has been replaced with redirecting to theGITHUB_OUTPUTenvironment variable (if theGITHUB_ACTIONSenvironment variable istrue, as it will always be when running in GitHub Actions).Note, this also ignores the safety ID related to jinja2, see GHSA-f6pv-j8mr-w6rr for more information.