Adding secrets cat command and removing secrets get command
#282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryanjassal
force-pushed
the
feature-unix-cat
branch
from
a657c99
to
77800f9
Compare
[ci skip] feat: removed Secrets/CommandGet and added tests [ci skip] chore: working on stdin test [ci skip] bug: working on adding test for stdin to stdout [ci skip bug: still working on that error [ci skip] chore: fixed stdin test [ci skip] feat: updated secrets edit with new secrets get RPC [ci skip] fix: build [ci skip]
aryanjassal
force-pushed
the
feature-unix-cat
branch
from
1961d58
to
24bcc4f
Compare
aryanjassal
commented
Sep 20, 2024
Comment on lines
+74
to
+76
| if (!(await response.output).success) { | ||
| throw new errors.ErrorPolykeyCLIFileRead('Failed to delete file'); | ||
| } |
There was a problem hiding this comment.
I need feedback on this. How do I handle a non-zero success code?
In Polykey, the RPC will either return a true success code, or throw an error. It will never return a non-zero success code. To ignore the return code (which, in this case, is what we can do) and simply await the output, we can do this:
await response.outputOr do I need to properly handle it? I guess handling it properly would be future-proof, but I would need to make proper error throwing and handling. I'm not sure if an error already exists which can be thrown at a non-zero return code.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tracks the status of implementing
secrets catcommand, which can be used to concatenate multiple secrets together.Issues Fixed
secrets catcommand #243Tasks
secrets catcommandsecrets getcommandstdinto stdout if no arguments are providedFinal checklist