Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Silent loading and saving of bookmarks (for extensions) #46

Merged
merged 5 commits into from
May 21, 2014

Conversation

sbt-88
Copy link

@sbt-88 sbt-88 commented May 20, 2014

This change adds silent operation mode to functions SaveBookmarks an LoadBookmars, and makes LoadBookmarks return a status value. The quick&dirty script in examples/ directory shows how this may be used to automatically load/save separate bookmarks list when viewing a file in a specific location.

I'm new to git, and it appears I messed with the commit title somehow. Is there a way to fix it?

@MattesGroeger MattesGroeger changed the title Minimal support for bookmark groups management Silent loading and saving of bookmarks May 21, 2014
@MattesGroeger
Copy link
Owner

Hey @sbt-88, thanks again for your contribution.

Do I understand correctly that your example script loads the bookmarks per file? If so, what is the benefit? It would be great if you could also update the documentation accordingly (Readme.md and doc/bookmarks.txt).

Feel free to update this pull request. I updated the title already.

@MattesGroeger MattesGroeger added this to the 1.2.0 milestone May 21, 2014
@sbt-88
Copy link
Author

sbt-88 commented May 21, 2014

Not per file - per file system node. You call the AddBookmarksRoot for each directory, that should have it's own local bookmarks collection. Then, every time you edit a file that is within the directory added, or its' subdirectory, script will automatically switch to that local collection.

In any event, the example is just that. The point of the proposed enhancement is to allow user to write their own script for the management of collections of bookmarks in any way they want.

I'll update documentation later today and will update the pull request.

@sbt-88
Copy link
Author

sbt-88 commented May 21, 2014

I've updated the documentation and extended a feature a bit. Is there anything else I should add?

@MattesGroeger
Copy link
Owner

Thanks for the additions and the explanation. That sounds great! This means I can get project-specific bookmarks loaded without them to show up in other projects. That would be really helpful! I think this should be part of the plugin itself. Don't you think? Maybe you could make this feature configurable? Really great work 👍 👍 👍

@sbt-88
Copy link
Author

sbt-88 commented May 21, 2014

Well, I'm merely slightly expanding the scripts' interface to better suit my needs. I suppose, addition of such a feature into the plugin itself would require the full overhaul of the auto-save mechanism, which is outside of the scope of my current intent.

@MattesGroeger
Copy link
Owner

Alright ;) Thanks anyway. Maybe I can built on top of what you did if I find time.

MattesGroeger pushed a commit that referenced this pull request May 21, 2014
Silent loading and saving of bookmarks
@MattesGroeger MattesGroeger merged commit e4593ab into MattesGroeger:master May 21, 2014
@MattesGroeger MattesGroeger changed the title Silent loading and saving of bookmarks Silent loading and saving of bookmarks (for extensions) May 21, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants