Skip to content

Exception message is empty when required command options is missing #114

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Matthiee opened this issue Jan 2, 2021 · 0 comments · Fixed by #115
Closed

Exception message is empty when required command options is missing #114

Matthiee opened this issue Jan 2, 2021 · 0 comments · Fixed by #115
Assignees
@Matthiee
Labels
bug Something isn't working Customer Reported Bugs reported by customers

Comments

@Matthiee
Copy link
Member

Matthiee commented Jan 2, 2021

When a CommandParseException occures the message is hardcoded to be empty.

CommandLineParser.Core/CommandLineParser/Core/Exceptions/CommandParseException.cs

Line 23 in bffdbee

: base(command, "", new AggregateException(innerExceptions))

This results in the printed errors to being empty.
@Matthiee Matthiee added bug Something isn't working Customer Reported Bugs reported by customers labels Jan 2, 2021
@Matthiee Matthiee self-assigned this Jan 2, 2021
Matthiee added a commit that referenced this issue Jan 3, 2021
@Matthiee
Write exception message correctly in case of CommandParseException. F…
9872574 
…ixes #114
Matthiee added a commit that referenced this issue Jan 3, 2021
@Matthiee
Add tests for #114
39cb2e5
Matthiee added a commit that referenced this issue Jan 3, 2021
@Matthiee
Improve when printing errors and usage occures
a352d01 
Actually fixes #114
@Matthiee Matthiee mentioned this issue Jan 3, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Matthiee Matthiee

Labels
bug Something isn't working Customer Reported Bugs reported by customers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Empty exception messages when command has missing required options MatthiWare/CommandLineParser.Core
1 participant
@Matthiee