Skip to content

Rework input parsing #89

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Matthiee opened this issue Sep 27, 2020 · 0 comments · Fixed by #94
Closed

Rework input parsing #89

Matthiee opened this issue Sep 27, 2020 · 0 comments · Fixed by #94
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Matthiee
Copy link
Member

Matthiee commented Sep 27, 2020

This will allow for #45 and #54 to be implemented.

@Matthiee Matthiee added the enhancement New feature or request label Sep 27, 2020
@Matthiee Matthiee self-assigned this Sep 27, 2020
@Matthiee Matthiee added this to the 0.4.1 milestone Sep 27, 2020
@Matthiee Matthiee linked a pull request Sep 28, 2020 that will close this issue
Matthiee added a commit that referenced this issue Sep 28, 2020
* Empty option prefixes are not allowed

* Short options need to have a length of 1

* Return results by yielding

* Add API obsolete safety test

* Add second implementation of argument manager that will work better

* Add command context to keep track of the current command

* Add logging

* Test run with ArgumentManager2 implementation

* Add logging in tests

* Implement input parsing feature v2 fixes #89

* Use new ArgumentManager everywhere

* Remove old ArgumentManager

* Inject IArgumentManager

* Remove non async versions
Matthiee added a commit that referenced this issue Oct 4, 2020
* Rework input parsing (#94)

* Empty option prefixes are not allowed

* Short options need to have a length of 1

* Return results by yielding

* Add API obsolete safety test

* Add second implementation of argument manager that will work better

* Add command context to keep track of the current command

* Add logging

* Test run with ArgumentManager2 implementation

* Add logging in tests

* Implement input parsing feature v2 fixes #89

* Use new ArgumentManager everywhere

* Remove old ArgumentManager

* Inject IArgumentManager

* Remove non async versions

* Implement order attribute

* Rename to ArgumentManager

* Fix ordered options need to be processed back to back or an exception will be thrown.

* Fix codefactor

* Add more tests
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant