Skip to content

Add DefaultResolver #58

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Nov 10, 2019
Merged

Add DefaultResolver #58

merged 6 commits into from
Nov 10, 2019

Conversation

Matthiee
Copy link
Member

Fixes #57

@Matthiee Matthiee added enhancement New feature or request Customer Reported Bugs reported by customers labels Nov 10, 2019
@Matthiee Matthiee added this to the 0.3.vNext milestone Nov 10, 2019
@Matthiee Matthiee self-assigned this Nov 10, 2019
@codecov-io
Copy link

codecov-io commented Nov 10, 2019

Codecov Report

Merging #58 into 0.3 will increase coverage by 0.56%.
The diff coverage is 90.9%.

@@           Coverage Diff           @@
##           0.3      #58      +/-   ##
=======================================
+ Coverage   84%   84.57%   +0.56%     
=======================================
  Files       42       43       +1     
  Lines      963     1037      +74     
=======================================
+ Hits       809      877      +68     
- Misses     154      160       +6

@Matthiee Matthiee merged commit 7414576 into 0.3 Nov 10, 2019
@Matthiee Matthiee deleted the issue-57-string-ctor branch November 10, 2019 14:48
@Matthiee Matthiee mentioned this pull request Feb 23, 2020
Matthiee added a commit that referenced this pull request Feb 23, 2020
* Add DefaultResolver (#58)

* Add default resolver that is capable of resolving types with string constructor. Fixes #57

* Add TryParse method detection

* Add Parse method finder as well.

* Add last test for Parse method

* Add Async API (#59)

* Add async api

* Add an async api for validations

* Add first async api test

* Add more async tests

* Add more async test cases

* Use Async version when parsing commands as well.

* Add validation tests

* Improve test coverage

* Fixes some styling issues spotted by codefactor.io (#62)

* Only display usages when no default values have been specified. (#63)

Fixes #60

* Fix code styling

* Update project to v0.3
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Customer Reported Bugs reported by customers enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants