Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(#487): Should validate start < end #489

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

MauricioRobayo
Copy link
Owner

closes #487

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 100.00% // Head: 98.80% // Decreases project coverage by -1.20% ⚠️

Coverage data is based on head (e508e43) compared to base (b81e30f).
Patch coverage: 98.30% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #489      +/-   ##
===========================================
- Coverage   100.00%   98.80%   -1.20%     
===========================================
  Files            3        5       +2     
  Lines           42       84      +42     
  Branches         6       28      +22     
===========================================
+ Hits            42       83      +41     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/holidays.ts 100.00% <ø> (ø)
src/index.ts 95.23% <92.85%> (-4.77%) ⬇️
src/helpers.ts 100.00% <100.00%> (ø)
src/utils/holidaysWithinInterval.ts 100.00% <100.00%> (ø)
src/utils/isHoliday.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MauricioRobayo MauricioRobayo merged commit a36aaf5 into main Feb 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should validate start < end
1 participant