Add components-sanitizers.sh #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harry-Ramsey
force-pushed
the
components-sanitizers
branch
4 times, most recently
from
36fc358 to
9997460
Compare
Harry-Ramsey
added
enhancement
Harry-Ramsey
force-pushed
the
components-sanitizers
branch
from
9997460 to
a406172
Compare
This commit adds multiple sanitizer components to TF-PSA-Crypto similar to those found in Mbed TLS. Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
This commit removes unnecessary components such as ssl-opt.sh, compat.sh and context-info.sh Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
Harry-Ramsey
force-pushed
the
components-sanitizers
branch
from
a406172 to
e7e54cb
Compare
This commit adds a way to generate the generated files necessary for compling the memsan test case. Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
ronald-cron-arm
removed
the
needs-reviewer
valeriosetti
approved these changes
Feb 7, 2025
valeriosetti
reviewed
Feb 7, 2025
Comment on lines
+44
to
+50
| cd $OUT_OF_SOURCE_DIR | ||
| cmake -DCMAKE_C_COMPILER=clang -DGEN_FILES=ON "$TF_PSA_CRYPTO_ROOT_DIR" | ||
| make | ||
|
|
||
| $TF_PSA_CRYPTO_ROOT_DIR/scripts/config.py set MBEDTLS_TEST_CONSTANT_FLOW_MEMSAN | ||
| cmake -DCMAKE_C_COMPILER=clang -DGEN_FILES=OFF -DCMAKE_BUILD_TYPE:String=MemSan "$TF_PSA_CRYPTO_ROOT_DIR" | ||
| make |
There was a problem hiding this comment.
Please apologize for the potentially dumb question. IIUC one possible reason for which we are not using a single cmake call here which both generates files and also enables MemSan is that we only want MemSan to be active on the library files, not on the test ones. Is my assumption correct?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds multiple sanitizer components to TF-PSA-Crypto similar to those found in Mbed TLS. Closes #130
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: