Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
Upon upgrading a Swift 4.2, there was a few errors:
MMPixelSDK/MMPixelConfig.swift
, line 35 & 37:Overlapping accesses to 'name', but modification requires exclusive access; consider copying to a local variable
sysctl
to nil. This argument (newval
) is not required to get the hardware name of the device.MMPixelSDK/MMPixelSDK.swift
, line 107:Initializer for conditional binding must have Optional type, not 'UUID'
testGetAddlParamsString
andtestGetAddlParamsStringWithHashedEmail
failingaddlParams
dictionary, the ordering of theaddlParams
was changed.