Refactored Random Dependents Removal-Addition into a Seperate Class #6013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extracted random dependent management logic from `Campaign` into a new `RandomDependents` class for better modularity and maintainability. - Added unit tests for `RandomDependents` to ensure functionality and moved related properties to a dedicated resource file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6013 +/- ##
============================================
+ Coverage 10.33% 10.35% +0.01%
- Complexity 6130 6146 +16
============================================
Files 1039 1040 +1
Lines 139393 139413 +20
Branches 20674 20676 +2
============================================
+ Hits 14411 14440 +29
+ Misses 123536 123518 -18
- Partials 1446 1455 +9 ☔ View full report in Codecov by Sentry. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Campaigninto a newRandomDependentsclass for better modularity and maintainability.RandomDependentsto ensure functionality and moved related properties to a dedicated resource file.