Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Subsequent builds do not clear NXPorts.Attributes.dll from output directory #65

Closed
MeikTranel opened this issue Aug 19, 2021 · 0 comments
Closed

Subsequent builds do not clear NXPorts.Attributes.dll from output directory #65

MeikTranel opened this issue Aug 19, 2021 · 0 comments
Assignees
@MeikTranel
Labels
bug Something isn't working
Milestone
1.1

Comments

@MeikTranel
Copy link
Owner

When subsequently building without triggering a new compile NXPorts.Attributes.dll will get copied to the output directory again.
@MeikTranel MeikTranel added the bug Something isn't working label Aug 19, 2021
@MeikTranel MeikTranel added this to the 1.0 milestone Aug 19, 2021
@MeikTranel MeikTranel self-assigned this Aug 19, 2021
MeikTranel added a commit that referenced this issue Aug 29, 2021
@MeikTranel
Fixed subsequent builds not removing NXPorts.Attributes.dll
9716ede 
Once a dll has already been built and incremental shortcircuit
mechanisms kick in TargetsTriggeredByCompilation dont get
called anymore since no compilation took place.

Since the SDK still needs to communicate the output graph to
dependent projects or simply to fix removed  first class dependencies
the "PrepareForRun" / "ResolveReferences" suite of targets
still calculates files targeted for output directory publishing.

We now attach the NXPorts.Attributes.dll removal at the front
of PrepareForRun to guarantee it doesnt end up in the output after
incremental builds.

Resolves #65
@MeikTranel MeikTranel modified the milestones: 1.0, 1.1 Oct 27, 2021
@MeikTranel MeikTranel changed the title Subsequent Builds do not clear NXPorts.Attributes.dll from output directory Subsequent builds do not clear NXPorts.Attributes.dll from output directory Oct 31, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@MeikTranel MeikTranel

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@MeikTranel