Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Report overlapping export definitions to avoid undefined behavior caused by duplicate aliases #76

Closed
MeikTranel opened this issue Aug 29, 2021 · 0 comments · Fixed by #81
Closed

Report overlapping export definitions to avoid undefined behavior caused by duplicate aliases #76

MeikTranel opened this issue Aug 29, 2021 · 0 comments · Fixed by #81
Assignees
@MeikTranel
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
1.1

Comments

@MeikTranel
Copy link
Owner

NXPorts & .NET Framework currently allow for a DLL to export two functions using the same alias. This results in multiple entries in the export table with the same function name. This is allowed behavior since export functions are identified by their cardinal index in the export table; in 99% cases however this entirely undesired behavior since no one really loads via index.
@MeikTranel MeikTranel self-assigned this Aug 29, 2021
@MeikTranel MeikTranel added enhancement New feature or request good first issue Good for newcomers labels Aug 29, 2021
@MeikTranel MeikTranel added this to the Future milestone Aug 29, 2021
MeikTranel added a commit that referenced this issue Oct 18, 2021
@MeikTranel
Added improved diagnostics and refactored test suite
55db154 
* adds infrastructure for localization
* upgrade to more modern language idioms
* adds detection of duplicate aliases

Resolves #76
@MeikTranel MeikTranel mentioned this issue Oct 18, 2021
Merged
MeikTranel added a commit that referenced this issue Oct 18, 2021
@MeikTranel
Added improved diagnostics and refactored test suite
c1b7415 
* adds infrastructure for localization
* upgrade to more modern language idioms
* adds detection of duplicate aliases

Resolves #76
MeikTranel added a commit that referenced this issue Oct 18, 2021
@MeikTranel
Added improved diagnostics and refactored test suite (#81)
7ecfeb8 
* adds infrastructure for localization
* upgrade to more modern language idioms
* adds detection of duplicate aliases

Resolves #76
@MeikTranel MeikTranel modified the milestones: Future, 1.1 Oct 27, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@MeikTranel MeikTranel

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Added improved diagnostics and refactored test suite MeikTranel/NXPorts
1 participant
@MeikTranel