Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Property 'refresh' does not exist on type 'Map' #231

Closed
chrstnbwnkl opened this issue Jul 27, 2023 · 2 comments
Closed

Property 'refresh' does not exist on type 'Map' #231

chrstnbwnkl opened this issue Jul 27, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@chrstnbwnkl
Copy link

Describe the bug
The OlMap component exposes a refresh function that calls a refresh method on the map instance. However, I don't seem to find such a method on the ol.Map class.

Affected version(s)

Please run npm list --depth=0 vue vue3-openlayers ol ol-ext ol-contextmenu and paste the output below:

├── ol-contextmenu@5.2.1
├── ol-ext@4.0.8
├── ol@7.4.0
└── vue@3.3.4

To Reproduce
Steps to reproduce the behavior:

Simply install the project locally and inspect the OlMap component in the IDE of your choice. TypeScript should be complaining.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. macOS]
  • Browser [e.g. chrome, safari]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone 14]
  • OS: [e.g. iOS 16.15.1]
  • Browser [e.g. chrome, safari]

Additional context
Add any other context about the problem here.

@chrstnbwnkl chrstnbwnkl added the bug Something isn't working label Jul 27, 2023
@chrstnbwnkl
Copy link
Author

chrstnbwnkl commented Jul 27, 2023

Ah, I just realized this is just to make it backwards compatible with older ol versions, nevermind. Maybe this could be briefly added to the "Get started" section in the docs? Since there, it says that ^7.4.0 is required. Or has it just not been removed yet? 😄

@d-koppenhagen
Copy link
Collaborator

Thanks for reporting @chrstnbwnkl . Indeed it was simply not removed in this lib.
I removed this methods and other methodas and props that aren't compatible with OpenLayers 7.x.x.
See 81c6d00.

chrstnbwnkl pushed a commit to chrstnbwnkl/vue3-openlayers that referenced this issue Sep 15, 2023
The following removed props and methods were removed since they aren't compatible with the required OpenLayers version 7.4.0.
Please refer to the BREAKING CHANGES in the OpenLayers docs form the major release 7.0.0: https://github.com/openlayers/openlayers/releases/tag/v7.0.0

closes MelihAltintas#231
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants