feat(ol-style-text): added fill and stroke props #283
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the awesome library, it has saved me a ton of work. I've been trying to style some labels over map markers, and realized that I was unable to set the color of the text nor the stroke.
Description
Upon further digging, I came across this PR so I followed the same template used there and just added the missing props.
Motivation and Context
These two props are important to style text, and
OlStyleText
already implements those.How Has This Been Tested?
I tested this by pointing my project's npm to my local copy and tested the color and stroke modifications according to usage.
Screenshots (if appropriate):
Types of Changes
Checklist:
If you added a new component feature (layer, geom, source, etc.), please be sure to update the documentation:
output.globals
invite.config.ts
src/demos/<Component>Demo.vue
docs/componentsguide/<Category>/<Feature>/index.md
containing the Demo and documentation for the componentdocs/.vitepress/config.ts