Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(ol-style-text): added fill and stroke props #283

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

chady
Copy link
Contributor

@chady chady commented Dec 1, 2023

Thank you for the awesome library, it has saved me a ton of work. I've been trying to style some labels over map markers, and realized that I was unable to set the color of the text nor the stroke.

Description

Upon further digging, I came across this PR so I followed the same template used there and just added the missing props.

Motivation and Context

These two props are important to style text, and OlStyleText already implements those.

How Has This Been Tested?

I tested this by pointing my project's npm to my local copy and tested the color and stroke modifications according to usage.

Screenshots (if appropriate):

Screenshot 2023-11-30 at 9 10 45 PM Screenshot 2023-11-30 at 9 11 39 PM Screenshot 2023-11-30 at 9 12 31 PM

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (Tooling, Dependency Updates, etc.)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

If you added a new component feature (layer, geom, source, etc.), please be sure to update the documentation:

  • Add component to output.globals in vite.config.ts
  • Create a src/demos/<Component>Demo.vue
  • Create a docs/componentsguide/<Category>/<Feature>/index.md containing the Demo and documentation for the component
  • Add the docs page to docs/.vitepress/config.ts

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for vue3openlayers ready!

Name Link
🔨 Latest commit 3030bfc
🔍 Latest deploy log https://app.netlify.com/sites/vue3openlayers/deploys/656941692920320008403bc5
😎 Deploy Preview https://deploy-preview-283--vue3openlayers.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@d-koppenhagen d-koppenhagen merged commit b2e1147 into MelihAltintas:main Dec 3, 2023
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants