Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ol-overlay): prevent re-compute overlay, use shallowRef instead a… #322

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

d-koppenhagen
Copy link
Collaborator

@d-koppenhagen d-koppenhagen commented Mar 25, 2024

…nd watch property changes

this makes autoPan work.

closes #257

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Tests
  • Other (Tooling, Dependency Updates, etc.)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I added a new test.

If you added a new component feature (layer, geom, source, etc.), please be sure to update the documentation:

  • Add component to output.globals in vite.config.ts
  • Provide at least one simple snapshot test (see test directory)
  • Create a src/demos/<Component>Demo.vue
  • Create a docs/componentsguide/<Category>/<Feature>/index.md containing the Demo and documentation for the component
  • Add the docs page to docs/.vitepress/config.ts

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for vue3openlayers ready!

Name Link
🔨 Latest commit 0ea69a2
🔍 Latest deploy log https://app.netlify.com/sites/vue3openlayers/deploys/6601e7d84e941b00089c9e16
😎 Deploy Preview https://deploy-preview-322--vue3openlayers.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…nd watch property changes

this makes `autoPan` work.

closes #257
@d-koppenhagen d-koppenhagen merged commit b1bb37e into main Mar 25, 2024
5 checks passed
@d-koppenhagen d-koppenhagen deleted the overlay-fix-pan branch March 25, 2024 21:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoPan give error
1 participant