Skip to content

Fix some of TS typing issues #400

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

azygis
Copy link
Contributor

@azygis azygis commented Dec 18, 2024

Description

Types for features property is wrong on vector source amongst some other places. This PR is making them right.

Motivation and Context

Fixes #399.

How Has This Been Tested?

vitest and playwright tests have been run. Typings should not impact the functionality itself though.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Tests
  • Other (Tooling, Dependency Updates, etc.) - TS typings

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I added a new test.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for vue3openlayers ready!

Name Link
🔨 Latest commit 7c5c593
🔍 Latest deploy log https://app.netlify.com/sites/vue3openlayers/deploys/67ab225ad9842c00087020d1
😎 Deploy Preview https://deploy-preview-400--vue3openlayers.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@d-koppenhagen d-koppenhagen merged commit 198effc into MelihAltintas:main Feb 11, 2025
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type on OlSourceVector.features
2 participants