Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use package directory location instead SrcRoot #1

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Use package directory location instead SrcRoot #1

merged 1 commit into from
Nov 25, 2021

Conversation

obalunenko
Copy link

@obalunenko obalunenko commented Nov 24, 2021 •
edited
Loading

This allow to be path-agnostic of the gizmo root location.
https://pkg.go.dev/go/build#Package.Dir

@obalunenko
Use package directory location instead SrcRoot
db02c65 
This allow to be path-agnostic of the gizmo root location.
@obalunenko obalunenko requested a review from TursMA November 24, 2021 12:28
@obalunenko obalunenko added the enhancement New feature or request label Nov 24, 2021
@obalunenko
Copy link
Author

obalunenko commented Nov 24, 2021 •
edited
Loading

Tested locally in gizmo by replacing current version of prep with compiled locally with PR changes.

@obalunenko obalunenko merged commit 8165a9d into master Nov 25, 2021
@obalunenko obalunenko deleted the gizmo-root-path-agnostic branch November 25, 2021 14:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@TursMA TursMA TursMA approved these changes

Assignees

@TursMA TursMA

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obalunenko @TursMA