Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Fix post process type casting #110

Merged
merged 1 commit into from
Aug 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions tap_facebook/streams.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,11 @@ def post_process(
row: dict,
context: dict | None = None, # noqa: ARG002
) -> dict | None:
row["inline_link_clicks"] = int(row["inline_link_clicks"])
row["impressions"] = int(row["impressions"])
row["reach"] = int(row["reach"])
row["inline_link_clicks"] = int(row["inline_link_clicks"]) if "inline_link_clicks" in row else None
row["impressions"] = int(row["impressions"]) if "impressions" in row else None
row["reach"] = int(row["reach"]) if "reach" in row else None
return row


# ads stream
class AdsStream(FacebookStream):
"""Ads stream class.
Expand Down Expand Up @@ -1464,10 +1463,10 @@ def post_process(
row: dict,
context: dict | None = None, # noqa: ARG002
) -> dict | None:
row["amount_spent"] = int(row["amount_spent"])
row["balance"] = int(row["balance"])
row["min_campaign_group_spend_cap"] = int(row["min_campaign_group_spend_cap"])
row["spend_cap"] = int(row["spend_cap"])
row["amount_spent"] = int(row["amount_spent"]) if "amount_spent" in row else None
row["balance"] = int(row["balance"]) if "balance" in row else None
row["min_campaign_group_spend_cap"] = int(row["min_campaign_group_spend_cap"]) if "min_campaign_group_spend_cap" in row else None
row["spend_cap"] = int(row["spend_cap"]) if "spend_cap" in row else None
return row


Expand Down
30 changes: 30 additions & 0 deletions tests/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,13 @@
from singer_sdk.testing import SuiteConfig, get_tap_test_class

from tap_facebook.tap import TapFacebook
from tap_facebook.streams import AdsInsightStream, AdAccountsStream

SAMPLE_CONFIG = {
"start_date": "2023-03-01T00:00:00Z",
"api_version": "v16.0",
"access_token": "xxx",
"account_id": "xxx"
}

TestTapFacebook = get_tap_test_class(
Expand All @@ -17,3 +20,30 @@
max_records_limit=20,
),
)


def test_ads_insights_post_process():
row = {"reach": "0", "impressions": "1"}

ads_insights_stream = AdsInsightStream(tap=TapFacebook(config=SAMPLE_CONFIG))

post_processed_row = ads_insights_stream.post_process(row)

assert post_processed_row['inline_link_clicks'] is None
assert post_processed_row['reach'] == 0
assert post_processed_row['impressions'] == 1



def test_ads_accounts_post_process():
row = {"amount_spent": "0", "balance": "1", "min_campaign_group_spend_cap": "2"}

ads_accounts_stream = AdAccountsStream(tap=TapFacebook(config=SAMPLE_CONFIG))

post_processed_row = ads_accounts_stream.post_process(row)

assert post_processed_row['spend_cap'] is None
assert post_processed_row['amount_spent'] == 0
assert post_processed_row['balance'] == 1
assert post_processed_row['min_campaign_group_spend_cap'] == 2