Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: various cleanup and fixes #137

Merged
merged 6 commits into from
Jan 23, 2024
Merged

refactor: various cleanup and fixes #137

merged 6 commits into from
Jan 23, 2024

Conversation

pnadolny13
Copy link
Collaborator

@pnadolny13 pnadolny13 commented Jan 22, 2024

Includes the changes from #135 and #133

  • cleanup unneeded methods
  • fix replication keys and incremental enum references
  • fix sort keys that were throwing errors
  • fix custom audience columns property inheritance
  • fix tests and CI

pnadolny13 and others added 4 commits January 16, 2024 13:07
…133)

* fix replication method to proper enum and remove duplicate methods

* [pre-commit.ci] auto fixes

* use incremental constant vs string

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* replication IDs, deprecation warnings, docs links updates

* [pre-commit.ci] auto fixes

* fix custom audience column joining

* [pre-commit.ci] auto fixes

* revert links

* revert another link change

* add todo links

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pnadolny13 pnadolny13 merged commit 30db1b1 into main Jan 23, 2024
5 checks passed
@pnadolny13 pnadolny13 deleted the main_refactor branch January 23, 2024 15:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants