Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Show dialog when active contributors per month limit is hit #3676

Merged
merged 19 commits into from
Nov 25, 2024

Conversation

ValentinBuira
Copy link
Contributor

@ValentinBuira ValentinBuira commented Nov 14, 2024

This PR add a new dialog when user try to sync while they have already hit the active contributor per month limit

Screenshot from 2024-11-14 12-32-41

Note for reviewer the error live and is triggered in synchronizationerror and synchronizationmanager

Resolve https://github.com/orgs/MerginMaps/projects/15/views/1?pane=issue&itemId=86203521

Copy link

github-actions bot commented Nov 14, 2024

Pull Request Test Coverage Report for Build 12008537298

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 181 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 60.376%

Files with Coverage Reduction New Missed Lines %
input/core/merginapi.h 1 97.56%
input/app/mmstyle.h 50 1.94%
input/core/merginapi.cpp 130 78.51%
Totals Coverage Status
Change from base Build 11788282153: -0.02%
Covered Lines: 7876
Relevant Lines: 13045

💛 - Coveralls

Copy link
Contributor

@VitorVieiraZ VitorVieiraZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I’ve left only comments about code styling and a suggestion for when apiSupportsSubscriptions is false.

Copy link
Contributor

@VitorVieiraZ VitorVieiraZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny change, feel free to merge once adjusted 👍🏻 Thanks!

@tomasMizera
Copy link
Collaborator

Fix tests

... aand yes, we will need to fix tests in case they will still be failing once the CI is re-run

@ValentinBuira ValentinBuira merged commit 3111207 into master Nov 25, 2024
12 checks passed
@ValentinBuira ValentinBuira deleted the active-contributor-dialog branch November 25, 2024 11:49
@alexd0793 alexd0793 added the test-success Label to use for PR testing label Dec 2, 2024
@tomasMizera
Copy link
Collaborator

We need revert here @ValentinBuira

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
test-success Label to use for PR testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show dialog when active contributors per month limit is hit [mobile]
5 participants