Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

boards: meshme CC2538 + CC2592 initial implementation #290

Merged
merged 1 commit into from
Jul 11, 2022
Merged

boards: meshme CC2538 + CC2592 initial implementation #290

merged 1 commit into from
Jul 11, 2022

Conversation

luisan00
Copy link
Contributor

@luisan00 luisan00 commented Jul 5, 2022 •
edited
Loading

Contribution description

meshme is in a early stage, it combine the CC2538 SoC and a CC2592 Front End, both from Texas Instruments.
This PR, add support for the "meshme" board, at least some basic support

Testing procedure

build and flash the board with some networking example

Issues/PRs references

None

@luisan00 luisan00 added this to the 0.22.12-RC1 milestone Jul 5, 2022
CW-75
CW-75 previously requested changes Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some checks found by the static-test, I propose the following suggestions

@CW-75 CW-75 dismissed their stale review July 5, 2022 18:12

This it's in progress

@luisan00 luisan00 changed the title [WIP] boards: meshme CC2538 + CC2592 initial implementation boards: meshme CC2538 + CC2592 initial implementation Jul 7, 2022
@luisan00 luisan00 requested review from CW-75 and RocioRojas July 7, 2022 12:02
@luisan00 luisan00 force-pushed the board/cc2538 branch 2 times, most recently from c8766e8 to 51a4975 Compare July 7, 2022 17:16
CW-75
CW-75 requested changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, only have a little details to merge. Go ahead 👍

@luisan00
Copy link
Contributor Author

luisan00 commented Jul 9, 2022

@RocioRojas @eduazocar requested changes done! but looks like some conflicts appear right now

@luisan00
Copy link
Contributor Author

luisan00 commented Jul 9, 2022

all changes done!

@luisan00 luisan00 requested review from RocioRojas and CW-75 July 9, 2022 08:46
CW-75
CW-75 reviewed Jul 9, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see all good, I think this is ready to merge, but first do the squash to approve it

@luisan00
Copy link
Contributor Author

luisan00 commented Jul 9, 2022

done @eduazocar !

@luisan00 luisan00 requested a review from CW-75 July 9, 2022 09:03
@RocioRojas
Copy link
Contributor

RocioRojas commented Jul 9, 2022 •
edited
Loading

I look good for me !!!

CW-75
CW-75 approved these changes Jul 10, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, it's time to merge it 👍

@luisan00 luisan00 merged commit 24bddd4 into Mesh4all:main Jul 11, 2022
@luisan00 luisan00 deleted the board/cc2538 branch July 11, 2022 09:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@CW-75 CW-75 CW-75 approved these changes

@RocioRojas RocioRojas Awaiting requested review from RocioRojas

Assignees
No one assigned
Labels
Area: boards Area: doc Area: firmware Area: Kconfig Area: sys Area: tests Platform: m4a-24g Platform: m4a-mb Platform: meshme
Projects
None yet
Milestone
0.22.12-RC1
Development

Successfully merging this pull request may close these issues.
3 participants
@luisan00 @RocioRojas @CW-75