Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Network: Made kconfig to at_client #304

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Network: Made kconfig to at_client #304

merged 1 commit into from
Jul 11, 2022

Conversation

RocioRojas
Copy link
Contributor

Contribution description

Made kconfig to at client module with the kconfig sets the configuration to baudrate default, shell and uart buff size

Testing procedure

Run in terminal make menuconfig, look for the option at client and choose baudrate default, shell and uart buff size

Issues/PRs references

@RocioRojas RocioRojas added this to the 0.22.12-RC1 milestone Jul 8, 2022
@RocioRojas RocioRojas changed the title Network: Made kconfig at_client Network: Made kconfig to at_client Jul 8, 2022
CW-75
CW-75 requested changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that, the assignation of baud-rates should be exactly and not writable by the user. e.g if i don't know the baudrates standards could be set an value as 7548 baud-rates

@RocioRojas RocioRojas force-pushed the at_kconfig branch 2 times, most recently from f03001b to 6708db8 Compare July 11, 2022 03:14
CW-75
CW-75 requested changes Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference of time to wait a response is not
microseconds, fix it in the kconfig and the doc comment

CW-75
CW-75 reviewed Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job a little fix and this will be ready

CW-75
CW-75 requested changes Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍 , go ahead

CW-75
CW-75 approved these changes Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍 , go ahead

@RocioRojas RocioRojas merged commit 13ad848 into Mesh4all:main Jul 11, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@CW-75 CW-75 CW-75 approved these changes

Assignees
No one assigned
Labels
Area: firmware Area: Kconfig Area: network Area: sys Area: tests
Projects
None yet
Milestone
0.22.12-RC1
Development

Successfully merging this pull request may close these issues.
2 participants
@RocioRojas @CW-75