Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Warn when input files don't exist #518

Merged
merged 4 commits into from
May 13, 2024
Merged

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Apr 22, 2024

Fixes #517

Description

Emmit a warning when an input file does not exist. This makes it easier to understand what needs fixing in rose-suite.conf

Fixes #517

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Added an entry to the top of docs/source/changelog.rst
  • Conda lock files have been updated if dependencies changed.
  • Marked the PR as ready to review.

@jfrost-mo jfrost-mo added the enhancement New feature or request label Apr 22, 2024
@jfrost-mo jfrost-mo self-assigned this Apr 22, 2024
Copy link
Contributor

github-actions bot commented Apr 22, 2024

Coverage

@jfrost-mo jfrost-mo marked this pull request as ready for review April 22, 2024 15:07
@jfrost-mo jfrost-mo force-pushed the 517_error_on_missing_inbput branch from 7c59e4d to a0f4502 Compare May 13, 2024 14:16
@jfrost-mo jfrost-mo force-pushed the 517_error_on_missing_inbput branch from a0f4502 to 2933f5a Compare May 13, 2024 14:22
@jfrost-mo jfrost-mo mentioned this pull request May 13, 2024
6 tasks
@jfrost-mo jfrost-mo merged commit 4e09327 into main May 13, 2024
7 checks passed
@jfrost-mo jfrost-mo deleted the 517_error_on_missing_inbput branch May 13, 2024 14:24
@jfrost-mo jfrost-mo removed the request for review from JKPShonk May 13, 2024 14:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading error message when input data file does not exist
2 participants