Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test and fix CSET_ADDOPTS with lists #569

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Apr 29, 2024

Description

Fixes #568

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Added an entry to the top of docs/source/changelog.rst
  • Conda lock files have been updated if dependencies changed.
  • Marked the PR as ready to review.

@jfrost-mo jfrost-mo added the bug Something isn't working label Apr 29, 2024
@jfrost-mo jfrost-mo self-assigned this Apr 29, 2024
Copy link
Contributor

github-actions bot commented Apr 29, 2024

Coverage

@jfrost-mo jfrost-mo marked this pull request as ready for review April 29, 2024 15:14
@Sylviabohnenstengel Sylviabohnenstengel merged commit 5288a0b into main Apr 29, 2024
8 checks passed
@Sylviabohnenstengel Sylviabohnenstengel deleted the 568_list_passthrough_crash branch April 29, 2024 15:17
@Sylviabohnenstengel Sylviabohnenstengel restored the 568_list_passthrough_crash branch April 29, 2024 15:18
@Sylviabohnenstengel Sylviabohnenstengel deleted the 568_list_passthrough_crash branch April 29, 2024 15:18
@Sylviabohnenstengel
Copy link
Contributor

happy with changes, please go ahead and merge.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cset crash when list passed in via CSET_ADDOPTS
2 participants