Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove invalid rose meta trigger for removed variable #733

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Remove invalid rose meta trigger for removed variable #733

merged 2 commits into from
Jul 5, 2024

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Jul 5, 2024 •
edited
Loading

It currently causes rose-edit to complain, and is not needed.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jfrost-mo jfrost-mo added bug Something isn't working small Small issue that should be quick to resolve labels Jul 5, 2024
@jfrost-mo jfrost-mo self-assigned this Jul 5, 2024
@jfrost-mo jfrost-mo requested a review from daflack July 5, 2024 09:51
@jfrost-mo jfrost-mo marked this pull request as ready for review July 5, 2024 09:51
@jfrost-mo jfrost-mo changed the title Remove rose meta trigger for removed variable Remove invalid rose meta trigger for removed variable Jul 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024 •
edited
Loading

Coverage

daflack
daflack reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@daflack daflack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update rose-suite.conf.example as well for this as it was still present in that file and would be good to tidy it up as well.

@jfrost-mo jfrost-mo requested a review from daflack July 5, 2024 10:00
daflack
daflack approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@daflack daflack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@daflack daflack merged commit 1220a36 into main Jul 5, 2024
7 checks passed
@daflack daflack deleted the cape_time_rose_metadata_fix branch July 5, 2024 10:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@daflack daflack daflack approved these changes

Assignees

@jfrost-mo jfrost-mo

Labels
bug Something isn't working small Small issue that should be quick to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfrost-mo @daflack