Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci/Update container to atlas v0.38.1 #114

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

twsearle
Copy link
Collaborator

@twsearle twsearle commented Aug 1, 2024

Description

Upgrade the CI container to use atlas 0.38.1 in container v1.3.0. Point the current CI to the container at atlas 0.37.0.

@twsearle twsearle requested a review from yaswant August 1, 2024 13:24
@twsearle twsearle self-assigned this Aug 1, 2024
@twsearle twsearle mentioned this pull request Aug 1, 2024
15 tasks
@twsearle
Copy link
Collaborator Author

twsearle commented Aug 1, 2024

@odlomax I think this setup I am experimenting with does what you wanted yesterday? - you can rebuild the container when you need to change the versions of some base packages, but you don't need to rebuild the container every time (container build takes 44 mins, ci takes 30 mins so I think its best not to roll into one set of actions that happens on every commit to a PR).

This is only a temporary solution, there are probably neater, nicer ways of working across the various Met Office repos. But its a proof of concept. It is also worth pointing out that the packages created are private to me - no-one can access my containers by default so I think its safe even for proprietary code (for now the image only contains open libraries).

@@ -7,7 +7,7 @@ on:
branches: [develop]
env:
REGISTRY: ghcr.io
IMAGE_NAME: twsearle/orca-jedi/ci-almalinux9:feature-use-personal-ghcr-container
IMAGE_NAME: twsearle/orca-jedi/ci-almalinux9:v1.2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a version bump in this PR, are you not planning to use 1.3.0 or is this a chicken-and-egg problem?

Copy link
Collaborator Author

@twsearle twsearle Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is the chicken and egg problem I am still figuring out. I actually realised I could combine this PR with #107 but not until after I had made it!

In this PR I update the container specification to v1.3.0 (containing atlas 0.38.1) but I keep the ci pegged at atlas 0.37.0 so that it still works with that version and will pass. At #107 I update the tests in orca-jedi for validity with 0.38.1, and I update to use the new container created by this PR (when I pushed the tag for v1.3.0)).

This is tricky to explain in text and I am happy to have a call if it helps! As I say, I think I could have combined the two PRs, but I did it this way because I was still understanding this stuff and wanted to make it clear that this PR only affects the container build, not orca-jedi, orca-jedi compatibility with atlas, or anything real - only #107 needs to be coordinated with the rest of mo-bundle changes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the reason for this specific line - I figured out that I can make tags even on my PRs - so the container in use on the previous PR should have originally read v1.2.0 as it was compatible with the VERSION of orca-jedi at v1.2.0.

@twsearle twsearle merged commit 0f16f83 into develop Aug 15, 2024
2 checks passed
@twsearle twsearle deleted the feature/update-container-to-atlas-0.38.1 branch August 15, 2024 09:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants