Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bugfix: geoVaLs vector ordering for profiles #13

Merged
merged 1 commit into from
Sep 1, 2022
Merged

bugfix: geoVaLs vector ordering for profiles #13

merged 1 commit into from
Sep 1, 2022

Conversation

twsearle
Copy link
Collaborator

@twsearle twsearle commented Aug 31, 2022

Description

The "results" vector that contains the GeoVaLs data output by the interpolator was defined in the wrong order. This is only an issue if there is more than one level in the data, as there is for profile data.

The ordering should be by variable, z-level, and then horizontal location, with the location varying the fastest. So for the example of profile of 2 observations with two observed variables, the corresponding geovals from a 3 level background field would look like this:

GeoVals ordering

Testing

  • The ctests have been adjusted here and in nemo-feedback #18 to reflect this change.
  • The geoVaLs were saved to file for some example data using the GOMSaver filter and double checked.

Copy link

@SusanSun17 SusanSun17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah Toby, you did it! 🥳

@twsearle
Copy link
Collaborator Author

twsearle commented Sep 1, 2022

thanks! Got there in the end :)

@twsearle twsearle merged commit 55e4d07 into MetOffice:develop Sep 1, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants