Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

bugfix: remove state variables from all "Model" classes #39

Merged
merged 1 commit into from
Jul 21, 2023
Merged

bugfix: remove state variables from all "Model" classes #39

merged 1 commit into from
Jul 21, 2023

Conversation

twsearle
Copy link
Collaborator

@twsearle twsearle commented Jul 21, 2023 •
edited
Loading

Bugfix to handle runtime errors from: https://github.com/JCSDA-internal/oops/pull/2258

Removes all references to state variables from configuration and dummy Model class.

Tests:

@twsearle twsearle self-assigned this Jul 21, 2023
@twsearle twsearle requested a review from matthewrmshin July 21, 2023 09:55
matthewrmshin
matthewrmshin approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my environment. Works as expected.

@twsearle twsearle merged commit 112d410 into develop Jul 21, 2023
@twsearle twsearle deleted the bugfix/remove-model-variables-spec branch November 16, 2023 14:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@matthewrmshin matthewrmshin matthewrmshin approved these changes

Assignees

@twsearle twsearle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twsearle @matthewrmshin