refactor: swap getValues for Interpolator #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARNING: This commit does not pass unittests This is because it doesn't seem to be possible to configure the interpolator. See https://github.com/JCSDA-internal/oops/pull/1680/files#r841592253 for details.
|
I have been told that there is no functionality to configure a custom interpolator right now, and that it will be added in a future commit. For compatibility with the nightly tests, and to make sure the code still builds I am merging this now. I will need to come back and fix all the broken unittests when this is possible. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapt to the refactor of GetValues in oops https://github.com/JCSDA-internal/oops/pull/1680
We trade the interpolator in GetValues for implementing our own LocalInterpolator class. This is because we are not using the generic oops interpolator to match the behaviour of the OPS. Unfortunately, it appears for the moment we have lost the ability to configure this interpolator.
Acceptance Criteria (Definition of Done)
Code builds and tests run.
WARNING: This commit does not pass unittests
This is because it doesn't seem to be possible to configure the interpolator. See https://github.com/JCSDA-internal/oops/pull/1680/files#r841592253 for details.
Dependencies
Impact
At present users will lose the ability to configure the interpolator.