Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reset to use single OMP process in tests #51

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

twsearle
Copy link
Collaborator

@twsearle twsearle commented Sep 11, 2023

Description

OpenMP parallisation is leading to test result differences under the cray-with-intel-libraries build. It is unclear why this is happening, but seeing as we can't reproduce using the other builds and this build will not be available on the new HPC, I am removing the test for OMP for now.

Issue(s) addressed

Resolves #50

Impact

Fixes nightly test failures from orca-jedi.

Testing

@twsearle twsearle added the bug Something isn't working label Sep 11, 2023
@twsearle twsearle self-assigned this Sep 11, 2023
@matthewrmshin
Copy link
Collaborator

(Test was failing for spice_intel We don't do gnu_intel any more.)

@twsearle
Copy link
Collaborator Author

(Test was failing for spice_intel We don't do gnu_intel any more.)

Ahh OK sorry! I misread. In an earlier test this did pass so I think the PR will still be good (it was a temporary build that has been overwritten, hence the named build linked in the PR above) My understanding is that even the spice_intel build is not long term? Is that correct?

Regardless, I will make an issue to turn this testing back on in the future. Clearly something strange is happening. The openMP is rather simple, so it is puzzling it works under all other builds. It only gives us a few percent speedup, so it is not a concern to switch it off for now.

Copy link
Collaborator

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Testing in my environment. Will approve when done.

Copy link
Collaborator

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my environment. Works as expected.

@twsearle twsearle merged commit c62f762 into develop Sep 11, 2023
@twsearle twsearle deleted the bugfix/sst-test-failure-omp branch November 16, 2023 14:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_orcamodel_hofx_sst failure on spice_intel
2 participants