macros and core rose-stem #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,11 +3,12 @@ | |||
| Testing LFRic Core | |||
| ================== | |||
|
|
|||
| LFRic testing is run with the following command from a working copy: | |||
| LFRic testing is now Cylc8 only and launched with rose-stem commands: | |||
There was a problem hiding this comment.
To make this slightly less of the moment I'd suggest just including the "export CYLC_VERSION=8" in the command and use this headline sentence to just say that LFRic Core uses rose-stem (like Apps, UM etc).
It might then be worth a "note" box to say that calling make test-suite was deprecated from the core2.0 revision or something like that?
source/WorkingPractices/macros.rst
Outdated
| @@ -92,6 +92,10 @@ The organisation of LFRic metadata is different from other repositories (UM + Ju | |||
|
|
|||
| To solve this, macros in LFRic Apps are applied using a wrapper script which will read the added macros and combine them into the versions.py files for the apps where that metadata is imported. Therefore when adding macros, the macro should be added in the versions.py file in the same metadata directory as the metadata change being made. It will then be shared as appropriate by the ``apply_macros.py`` script. | |||
|
|
|||
| .. tip:: | |||
|
|
|||
| The macro will only end up in versions.py files for metadata that is directly imported by a rose-stem app. Therefore if adding to eg. Science/gungho, the macro will be deleted from that file by the script. | |||
There was a problem hiding this comment.
I wonder if a final sentence on here to drive home the "make sure you're ready for things to be deleted" message?
Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com>
…ms into vn2.0_changes
|
Thanks Jenny, updated all those |
jennyhickson
approved these changes
Dec 19, 2024
yaswant
reviewed
Dec 19, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some clarifications to LFRic Upgrade Macros and change LFRic Core testing instructions to use cylc8 commands