#20 Labelled Exits #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewHambley
requested changes
Mar 7, 2022
MatthewHambley
approved these changes
Mar 7, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the rule outlined in #20 , along with some tests for it. One could also check for labels on do statements, though this is redundant, as code will not compile if an exit statement label exists without a matching do statement label.
Some background on the reason for wanting this via @AdamVoysey: The behaviour of unlabeled exit statements has subtly changed between different versions of the Fortran standard as new functionality has been added. So rather than say something like "if you're using Fortran 2003 you have to label these cases; if you are using Fortran 2008 you also have to label these" etc. we decided it was just easier to label everything, as that is not ambiguous or dependant on which compiler settings you use.