Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Yarn 4 compatibility #65

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix Yarn 4 compatibility #65

merged 1 commit into from
Apr 15, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Apr 13, 2024

Yarn 4's workspaces foreach requires --all (or another similar option) to be set explicitly:

Usage Error: Invalid option schema: missing at least one property from "all", "recursive", "since",
or "worktree"

Adding --all seems to match the existing behaviour in Yarn 3, and does not break backwards compatibility.

@Mrtenz Mrtenz requested a review from a team as a code owner April 13, 2024 10:07
Copy link
Contributor

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mrtenz Mrtenz merged commit f861a2b into main Apr 15, 2024
12 checks passed
@Mrtenz Mrtenz deleted the mrtenz/yarn-4-compatibility branch April 15, 2024 15:04
Gudahtt added a commit that referenced this pull request May 10, 2024
* origin/main:
  remove default channel (#73)
  Don't fail overall if Slack announcement fails (#69)
  Improve Dry Run Output (#64)
  5.0.0 (#67)
  Fix Yarn 4 compatibility (#65)
  Disallow publishing packages with version 0.0.0 (#63)
  Run linting and testing GitHub workflows on PRs (#62)
  Enabling MetaMask security code scanner (#60)
  Add Shared Libraries team in codeowners file (#59)
  Update README.md (#56)
  Update README.md (#55)
  Update README.md (#54)
  Bump word-wrap from 1.2.3 to 1.2.4 (#53)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants