Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add mask support #76

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Add mask support #76

merged 1 commit into from
Oct 18, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Oct 18, 2021

The logo now supports masks. A <mask> allows selectively making parts of the model partially or entirely transparent.

A demo of this functionality has been added, called "fade". It shows the regular fox fading out from bottom to top, except the eyes remain completely opaque.

@Gudahtt Gudahtt requested a review from a team as a code owner October 18, 2021 13:12
This was referenced Oct 18, 2021
The logo now supports masks. A `<mask>` allows selectively making parts
of the model partially or entirely transparent.

A demo of this functionality has been added, called "fade". It shows
the regular fox fading out from bottom to top, except the eyes remain
completely opaque.
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Demo tested locally.

@Gudahtt Gudahtt merged commit bb2caa7 into main Oct 18, 2021
@Gudahtt Gudahtt deleted the add-mask branch October 18, 2021 19:38
@Gudahtt Gudahtt mentioned this pull request Oct 22, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants