Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Errors when sending transaction to ledger #5641

Closed
wjmelements opened this issue Oct 30, 2018 · 9 comments
Closed

Errors when sending transaction to ledger #5641

wjmelements opened this issue Oct 30, 2018 · 9 comments
Assignees
@brunobar79
Labels
needs-reproduction

Comments

@wjmelements
Copy link
Contributor

wjmelements commented Oct 30, 2018 •
edited
Loading

Uncaught Error: new BigNumber() not a base 16 number: null

screen shot 2018-10-30 at 3 05 07 pm

Uncaught (in promise) Error: invalid transport instance

screen shot 2018-10-30 at 3 07 19 pm
@wjmelements
Copy link
Contributor Author

MetaMask version is 4.16.0. Chrome version is 70.0.3538.77.

@wjmelements
Copy link
Contributor Author

screen shot 2018-10-30 at 3 13 38 pm

@wjmelements
Copy link
Contributor Author

@brunobar79 ptal when you get a chance

@wjmelements
Copy link
Contributor Author

screen shot 2018-10-30 at 3 19 56 pm

@wjmelements
Copy link
Contributor Author

The immediate issue seems to be the invalid transport instance error.

@wjmelements
Copy link
Contributor Author

I was using the Ledger incorrectly so this issue should be subdivided into surfacing the error to the user better, as MyEtherWallet does, and addressing the BigNumber issue, which seems to be separate. Stringifying the error should be sufficient for the first item.

@brunobar79
Copy link
Contributor

@wjmelements Thanks for reporting! I'll take a look next week.

@brunobar79 brunobar79 self-assigned this Nov 15, 2018
@brunobar79 brunobar79 mentioned this issue Nov 15, 2018
Closed
@brunobar79
Copy link
Contributor

@wjmelements Just fixed the bad error message via #5791. Could you please provide steps to reproduce the BigNumber issue you mentioned above?
Thanks!

@brunobar79 brunobar79 mentioned this issue Nov 20, 2018
Merged
@bdresser
Copy link
Contributor

closing, happy to re-open with reproduction steps.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@brunobar79 brunobar79

Labels
needs-reproduction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wjmelements @bdresser @brunobar79 and others