Bump eth-ledger-bridge-keyring #5791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
previously approved these changes
Nov 20, 2018
|
Whoops, just noticed the conflict. I can re-approve after that's resolved. |
Good catch @whymarrh . Just fixed it |
|
@brunobar79 I think the lockfile might have been resolved incorrectly. I'm seeing 7,582 additions and 7,604 deletions which seems like a lot, it's just the one package that's been bumped here? |
brunobar79
force-pushed
the
fix-ledger-stuff
branch
from
a37176d to
738ed90
Compare
|
I think I was using a different node version by accident and that reformatted the whole package-lock.json 😬 As always... good catch @whymarrh! 🙏 |
|
Just a small note,
If we don't want to close that just yet we should update the description to something like "partial fix for" so that GitHub doesn't auto-close it. GitHub is particular with its wording. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version fixes the error format of the keyring (Now it returns an Error object, as expected by the TX controller) (see MetaMask/eth-ledger-bridge-keyring#8)
Partially addresses #5641