Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add download seed phrase link to new UI #4961

Merged
merged 3 commits into from
Aug 14, 2018

Conversation

whymarrh
Copy link
Contributor

@whymarrh whymarrh commented Aug 7, 2018

Closes #4883

This PR adds a link to download the seed phrase when onboarding in the new UI:

@whymarrh whymarrh requested review from danjm and alextsg August 7, 2018 05:05
@whymarrh
Copy link
Contributor Author

whymarrh commented Aug 7, 2018

@cjeria I'm open to a better design/better copy if you have time and ideas

alextsg
alextsg previously approved these changes Aug 7, 2018
@cjeria
Copy link
Contributor

cjeria commented Aug 7, 2018

@whymarrh From the screenshot above, the download link doesn't look clickable. Can you make it blue like our primary button color? I would update the copy to say "Download this Secret Backup Phrase and keep it stored safely on an external encrypted hard drive or storage medium."

@whymarrh
Copy link
Contributor Author

whymarrh commented Aug 7, 2018

Thanks, I'll change that

@whymarrh
Copy link
Contributor Author

@cjeria updated the image, let me know if that's better

@cjeria
Copy link
Contributor

cjeria commented Aug 14, 2018

I think it could be a bit more obvious like having a proper download button, but let's merge this one and take another design pass at it later on.

@whymarrh
Copy link
Contributor Author

Sounds good

@whymarrh whymarrh merged commit 9ba91e6 into MetaMask:develop Aug 14, 2018
@whymarrh whymarrh deleted the download-seed-phrase branch August 14, 2018 09:53
@tmashuang tmashuang mentioned this pull request Aug 15, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants